Fix opencl build by wrap #if-else-endif with \n #2086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Please review. opencl support currently is in a completely broken state. |
howard0su
changed the title
Collaborator
|
I hadn't noticed an issue, and neither did the users of koboldcpp or the people reviewing the PR which added those preprocessor lines. Which platform/configuration is completely broken? |
Contributor
Author
|
check #2065 , at least I can repro the issue on Windows 10 and Windows 11. I don't have Linux to test now. |
Hi, I haven't experienced kernel errors while running with OpenCL on my device. I'm running latest build. It may be Windows specific. |
Contributor
Author
|
another user reported the issue on Windows. Can I merge this? @ggerganov @0cc4m |
0cc4m
approved these changes
Jul 7, 2023
Collaborator
|
Sorry for the delay, haven't had much time in the last few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.